Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start running scalability presubmits against all PRs #7547

Merged
merged 2 commits into from
Apr 4, 2018
Merged

Start running scalability presubmits against all PRs #7547

merged 2 commits into from
Apr 4, 2018

Conversation

shyamjvs
Copy link
Member

@shyamjvs shyamjvs commented Apr 4, 2018

This implements phase-1 of our proposed scalability processes (minus making those pre-submits block, which I'll do once these jobs prove stable).

/cc @wojtek-t

@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t April 4, 2018 12:15
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 4, 2018
@shyamjvs
Copy link
Member Author

shyamjvs commented Apr 4, 2018

fyi - @krzyzacy @BenTheElder

@wojtek-t
Copy link
Member

wojtek-t commented Apr 4, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shyamjvs, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shyamjvs
Copy link
Member Author

shyamjvs commented Apr 4, 2018

/retest

@shyamjvs shyamjvs force-pushed the scalability-presubmits-run-on-every-pr branch from d9d0f76 to 243184f Compare April 4, 2018 12:33
@shyamjvs shyamjvs requested a review from rmmh as a code owner April 4, 2018 12:33
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2018
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@shyamjvs
Copy link
Member Author

shyamjvs commented Apr 4, 2018

Fixed presubmit - reapplying lgtm.

@shyamjvs shyamjvs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2018
@shyamjvs shyamjvs force-pushed the scalability-presubmits-run-on-every-pr branch from 243184f to b1e9f54 Compare April 4, 2018 15:35
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2018
@shyamjvs
Copy link
Member Author

shyamjvs commented Apr 4, 2018

Fixed the other presubmit for bazel - reapplying lgtm.

@shyamjvs shyamjvs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2018
@k8s-ci-robot k8s-ci-robot merged commit b0034b4 into kubernetes:master Apr 4, 2018
@k8s-ci-robot
Copy link
Contributor

@shyamjvs: Updated the config configmap

In response to this:

This implements phase-1 of our proposed scalability processes (minus making those pre-submits block, which I'll do once these jobs prove stable).

/cc @wojtek-t

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shyamjvs shyamjvs deleted the scalability-presubmits-run-on-every-pr branch April 4, 2018 15:43
This was referenced Apr 4, 2018
Merged
Merged
@shyamjvs
Copy link
Member Author

shyamjvs commented Apr 4, 2018

Ref umbrella - #4445

@BenTheElder
Copy link
Member

we're moving towards tide, if you want to run a job against all PRs but not have it blocking it needs to have skip_report: true. this job is failing heavily. https://k8s-gubernator.appspot.com/builds/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-e2e-gce-100-performance

@shyamjvs
Copy link
Member Author

shyamjvs commented Apr 4, 2018

Isn't 'true' the default for skip_report? Also, the fix for those failures is now merged - #7555

@rmmh
Copy link
Contributor

rmmh commented Apr 4, 2018

No, any unset fields default to zero values (false).

@shyamjvs shyamjvs mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@rmmh rmmh Awaiting requested review from rmmh

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shyamjvs @wojtek-t @k8s-ci-robot @BenTheElder @rmmh